feature: Unified TimeSeriesChart component
#879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idreyn
requested review from
mathcolo,
skaplan-dev,
devinmatte and
PatrickCleary
as code owners
PatrickCleary
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have an awful lot of duplicated code in our charts. Usually when I need to make one I copy some code from a similar chart and make some very minor adjustments. So I've decided to take a crack at a unified
TimeSeriesChartcomponent that we should be able to use as the basis for basically all the charts in the DD where the x-axis is time.Changes
No changes to existing functionality, only a new component that I'll definitely use for new work, and may start retrofitting into existing dashboard tabs.
Testing Instructions
npm run storybookand visit theTimeSeriesChartcomponent page. Here are some examples of what this can do with a fairly minimal configuration: